Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OSX build issues #54

Closed
chrisosaurus opened this issue Jul 13, 2016 · 5 comments
Closed

Mac OSX build issues #54

chrisosaurus opened this issue Jul 13, 2016 · 5 comments

Comments

@chrisosaurus
Copy link
Contributor

My work on #24 has left some users ( @daveyarwood ) unable to build, whereas @eriksvedang is still able to build.

Opening issue to track progress.

I am working on setting up travis-ci for mac, I have #53 waiting which adds travis linux builds.

@chrisosaurus
Copy link
Contributor Author

I lack a mac, so to help me I need:

mac osx install instructions for the deps

glfw3
rlwrap
libffi

I understand I can get libffi from homebrew or from our mac deps repo, but I would also like to know how our existing users are installing it.

I would also like some previously working mac osx build commands.

@chrisosaurus
Copy link
Contributor Author

@daveyarwood please see #55 and test, let me know what works.

@daveyarwood
Copy link

See my comments on #55 -- tl;dr, it works 👍 but only if I provide -DLIBFFI_INCLUDE_DIRS and -DLIBFFI_LIBRARIES with the correct locations for my system.

I wonder if the cmake step can check in a number of possible locations (like the place where Homebrew put my libffi), and use it if it's there, otherwise fall back to what it's currently doing?

@chrisosaurus
Copy link
Contributor Author

@daveyarwood awesome, so that is the first step, we have fixed the regression I accidentally introduced.

The next step will be to automate finding just like we do under Linux, we now have a carp-lang mac-deps-repo which has libffi within it - so worst case we can automate cloning of that to a known location and set the INCLUDE_DIRS and LIBRARIES paths automatically :)

@daveyarwood
Copy link

Awesome, sounds good!

On Jul 14, 2016 6:57 PM, "Chris Hall" notifications@github.com wrote:

@daveyarwood https://github.com/daveyarwood awesome, so that is the
first step, we have fixed the regression I accidentally introduced.

The next step will be to automate finding just like we do under Linux, we
now have a carp-lang mac-deps-repo which has libffi within it - so worst
case we can automate cloning of that to a known location and set the
INCLUDE_DIRS and LIBRARIES paths automatically :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEroFzdhENJPIFg5xyvn-Rx8zL2B21gpks5qVukHgaJpZM4JLAdR
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants