Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug related to CNN search? #49

Open
neouyghur opened this issue Dec 19, 2019 · 0 comments
Open

a bug related to CNN search? #49

neouyghur opened this issue Dec 19, 2019 · 0 comments

Comments

@neouyghur
Copy link

Hi, thanks for sharing the code. I am implementing the CNN part. I think the block_idx in forward function should be moded by 2 when CNN case as you used only two softmax. Could you check it? Thanks.

for block_idx in range(2*(self.args.num_blocks - 1) + 1):
logits, hidden = self.forward(inputs,
hidden,
block_idx,
is_embed=(block_idx == 0))

@neouyghur neouyghur changed the title a bug? a bug related to CNN search? Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant