Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probable error in model.py lines 84 and 87 #42

Closed
biswajitsc opened this issue Sep 24, 2016 · 3 comments
Closed

Probable error in model.py lines 84 and 87 #42

biswajitsc opened this issue Sep 24, 2016 · 3 comments

Comments

@biswajitsc
Copy link

biswajitsc commented Sep 24, 2016 •
edited

Shouldn't the order of "self.D_logits, self.D" and "self.D_logits_, self.D_" be reversed? Since discriminator returns in the order (prob, logit)
@biswajitsc biswajitsc changed the title Probable error in model.py line 87 Probable error in model.py lines 84 and 87 Sep 24, 2016
@carpedm20
Copy link
Owner

Yes, this is weird. Thanks for finding this!

@PhoenixDai Hi, I think you changed the order while fixing c8925bc. Is there any reason why?

@PhoenixDai
Copy link
Contributor

I'm investigating it. As far as I can recall, I believe I do have a reason but it might also be a typo. I will update you about my findings. Sorry for not documenting it.

@carpedm20 carpedm20 mentioned this issue Oct 7, 2016
Merged
@carpedm20
Copy link
Owner

Fixed with #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PhoenixDai @carpedm20 @biswajitsc