Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about the Dueling logic in network.py #6

Closed
liurida opened this issue Aug 10, 2016 · 1 comment
Closed

questions about the Dueling logic in network.py #6

liurida opened this issue Aug 10, 2016 · 1 comment

Comments

@liurida
Copy link

liurida commented Aug 10, 2016

Hi
It's really a good code for learning Reinforcement Learning.
In the network.py, I have 2 questions.

  1. I think you want to assert len(value_hidden_sizes) != 0 and len(advantage_hidden_sizes) != 0.
  2. About the Dueling part, the logic in code is layer contains value_hidden_sizes linear, then the layer is delivered to the next advantage logic. But I read the related paper, if I understand correct, it describes that the state-value and advantage are generated from the same source observation, then they're added together, and minus the mean advantage value.

Looking forward to your further response.

@carpedm20
Copy link
Owner

@liurida Thanks! You're totally right. That's a huge bug and I just fixed and commit the new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants