Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in emoji_lis and distinct_emoji_lis? #186

Closed
luni3359 opened this issue Sep 26, 2021 · 5 comments
Closed

Typo in emoji_lis and distinct_emoji_lis? #186

luni3359 opened this issue Sep 26, 2021 · 5 comments

Comments

@luni3359
Copy link

Not that I really mind, but I've been wondering whether or not "lis" stood for anything other than list without the t.
@cvzi
Copy link
Contributor

cvzi commented Sep 27, 2021

For the emoji_list method "location in string" would make sense.

@revolter
Copy link

revolter commented Dec 7, 2021

I too think that they're typos.

@cvzi
Copy link
Contributor

cvzi commented Dec 7, 2021

This was the original commit b1deea7 by @NeelShah18

@cvzi
Copy link
Contributor

cvzi commented Feb 10, 2022

I guess we could rename these in the version 2.0.0 that I am planning in #195

Maybe just to emoji.emoji_list() and emoji.distinct_emoji_list()?
Or emoji.findall() seems like a "Python name"?

@TahirJalilov
Copy link
Collaborator

Agree with you @cvzi

@cvzi cvzi mentioned this issue Jun 5, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@revolter @cvzi @luni3359 @TahirJalilov