Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need to call fastqc twice #141

Open
swzCuroverse opened this issue Mar 3, 2023 · 1 comment
Open

Don't need to call fastqc twice #141

swzCuroverse opened this issue Mar 3, 2023 · 1 comment

Comments

@swzCuroverse
Copy link

swzCuroverse commented Mar 3, 2023

There seems to be an extra step calling fastqc twice. Fastqc is designed to both fastqcs, you don't have to call it twice.
(1)

quality_control_forward:
run: bio-cwl-tools/fastqc/fastqc_2.cwl
in:
reads_file: rna_reads_fruitfly_forward
out: [html_file]

quality_control_reverse:
run: bio-cwl-tools/fastqc/fastqc_2.cwl
in:
reads_file: rna_reads_fruitfly_reverse
out: [html_file]

https://github.com/common-workflow-library/bio-cwl-tools/blob/release/fastqc/fastqc_1.cwl -- would allow you to do both. Not sure why we are using fastqc_2? Perhaps it is documented. This would make the workflow much easier to understand.

@swzCuroverse
Copy link
Author

swzCuroverse commented Mar 3, 2023

I think when fastqc_2 was written, it limits which data can be put in for some reasons but I believe fastqc can still be run on an array of files - as shown in fastqc_1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant