Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: reviewer suggestions #103

Merged
merged 10 commits into from
May 9, 2023
Merged

Conversation

HeidiSeibold
Copy link

The PR is work in progress. Please do not merge yet!

I am reviewing this lesson (see carpentries-lab/reviews#24) and as part of my review want to directly suggest some changes.

Copy link
Collaborator

@ewallace ewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are very nice and clarify several important points.

There was a tiny issue with typos (flagged up in a separate comment), otherwise I'm happy to merge.

Thanks!

@ewallace ewallace merged commit ce45639 into carpentries-lab:gh-pages May 9, 2023
zkamvar pushed a commit that referenced this pull request Aug 31, 2023
WIP: reviewer suggestions

Merging now as solid improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants