Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for _episode 21 #51

Open
emmasimp opened this issue Mar 12, 2024 · 2 comments
Open

Suggestion for _episode 21 #51

emmasimp opened this issue Mar 12, 2024 · 2 comments
Assignees

Comments

@emmasimp
Copy link

In the first code box:
$ git switch develop
$ git branch -c test-suite

Would it be better to use
$ git checkout -b test-suite

So you are automatically switched to the new test-suite branch? Or include the extra command
$ git switch test-suite

Because I dont think later in the code when it comes time to commit to the test-suite branch we actually say make sure to switch to the correct branch.

@douglowe
Copy link
Collaborator

Ahh, yes, it would be better to use git switch -c test-suite rather than git branch -c test-suite. We do mention this in the previous lesson in a call-out box, so we could use the command here and shouldn't confuse anyone. I'll change the material now.

@douglowe
Copy link
Collaborator

douglowe commented Mar 16, 2024

Or, should I switch to this code:

git branch -c develop test-suite
git switch test-suite

The original code depends on us being in the branch we want to base the new branch on - which is an implicit assumption that might not be clear to the student. Whereas this code explicitly choses the original branch you want to copy.

Perhaps it is better to switch to using switch in the main material, as noted above, and then add a call-out box for this explicit method above? Or is this going to confuse our students even more?

@douglowe douglowe self-assigned this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants