Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to training request workflow #1007

Closed
6 of 7 tasks
chrismedrela opened this issue Sep 18, 2016 · 5 comments
Closed
6 of 7 tasks

Small improvements to training request workflow #1007

chrismedrela opened this issue Sep 18, 2016 · 5 comments
Assignees

Comments

@chrismedrela
Copy link
Contributor

chrismedrela commented Sep 18, 2016

In the training requests list view:

  • Display dates in "created at" column using "yyyy-mm-dd" format to make the column compact.
  • Let users filter by state using multichoice widget (three checkboxes instead of one drop-down).
  • Display only pending and accepted requests by default.
  • Display email in submitter column.
  • Display email in submitter and matched trainee columns in a new line, below full name, so that the columns don't take too much space.

Other stuff:

  • Change validation rules so that a request is accepted when it's matched to a training (now it's accepted when it's matched with an account)
  • Change title of training request edit view to something meaningful (from TrainingRequest object to Training request #11)
@chrismedrela
Copy link
Contributor Author

@gvwilson, do you want me to enforce in validation rules that a pending request cannot be matched to a training and an accepted one must be matched to a training?

@gvwilson
Copy link
Contributor

Pending cannot be matched to training.

Accepted doesn't necessarily have to be matched to training: the use
case is:

  1. We have several training events coming up.
  2. We score applications and accept those that are to be distributed
    amongst the events.
  3. We then assign them to training events.

In this case, "accepted" is being used to filter/select applications.

@chrismedrela
Copy link
Contributor Author

@gvwilson, do you want any other choices (like "all")?
image
I think that a drop-down is faster to use than three checkboxes. And definitively easier to implement. Is it fine?

@gvwilson
Copy link
Contributor

gvwilson commented Sep 28, 2016 via email

@chrismedrela
Copy link
Contributor Author

PR #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants