Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived consent terms should not be required to create AMY profile #2404

Open
maneesha opened this issue May 1, 2023 · 2 comments
Open
Assignees

Comments

@maneesha
Copy link
Contributor

maneesha commented May 1, 2023

On the instructor training application (https://amy.carpentries.org/forms/request_training/) the May contact and Privacy policy fields do not show any valid options in the dropdowns.

@elichad
Copy link
Contributor

elichad commented May 2, 2023

Resolved this time around by setting old-may-contact and old-privacy-policy to not be required to create a profile, which prevents them from displaying on the instructor training application form.

For a more robust fix, we should filter Terms by archived status when retrieving them for forms or other purposes. Perhaps we should also enforce that an archived Term cannot be a required Term.

@maneesha
Copy link
Contributor Author

Fixed by updating required consents in Django admin panel.

@maneesha maneesha changed the title Valid options for consents don't show up on instructor training application Archived consent terms should not be required to create AMY profile May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants