Trainee PRs for shell-novice

[weaverbel]

I am going to work my way through the PRs from instructor training - so far I have liked one new exercise/challenge (swcarpentry/shell-novice#334) as I think it does test understanding of wildcards

[weaverbel]

I think it is confusing to ask two questions in a challenge - better to stick to one swcarpentry/shell-novice#343

[weaverbel]

I like the fact that people have to demonstrate they can do this - good testing of understanding of what they should have learned earlier with FOR loops swcarpentry/shell-novice#340

[weaverbel]

Most of the pull requests so far are short and easy to scan but this one is just huge and seems to have so many differences and I would find that intimidating ! swcarpentry/shell-novice#333

[weaverbel]

The two I have liked the best so far are from people I know ! I like this tip on how to debug a script swcarpentry/shell-novice#331 - not too long, and fairly easy to scan quickly.

[weaverbel]

Pull requests need to be short and specific - this one has far too many changes in it swcarpentry/shell-novice#326 - and there are typos in what has been changed which adds work for the maintainer. This one has two exercises swcarpentry/shell-novice#317 - I have suggested he break them into separate commits in case only one is wanted.

And this one has a challenge swcarpentry/shell-novice#319 that seems like a challenge for the sake of it rather than to do anything useful or relevant

[weaverbel]

Some PRs are too short ! swcarpentry/shell-novice#285 seems to be only half an exercise. Ditto swcarpentry/shell-novice#286 - I like this though it is more helper/advice than a challenge.

[weaverbel]

We do have a lot of long challenges - they are not bad, per se, but they take quite a long time to read - probably not ideal for teaching purposes: swcarpentry/shell-novice#287 and swcarpentry/shell-novice#288

[weaverbel]

This is good as a tip swcarpentry/shell-novice#290 as it prompts you with Are you sure? before you delete something forever

[weaverbel]

This is my favourite so far - it is a little bit long, but it tests knowledge and people would feel satisfied if they got it right. Also I like the add on challenge of trying to do the job with fewer commands which people could do/not do as they felt like it swcarpentry/shell-novice#300

[weaverbel]

A case of 'too much information' with this swcarpentry/shell-novice#306 and this swcarpentry/shell-novice#301 - both offer useful information but could be info overload for trainees in the class. In the category of 'good to know' but I would not recommend adding to core lessons.

[weaverbel]

In the not bad category - tests understanding/memory of what was taught swcarpentry/shell-novice#312

[gvwilson]

Agreed - in this case, we should have asked the trainee to flesh it out. This person was a bit of a special case, though, and has already qualified - I'll close the PR.

[hoytpr]

Regarding swcarpentry/shell-novice#326 it was indeed too long and (as my first PR) naive regarding PR etiquette. The PR was for instructor training, but unfortunately attempted to address issues seen on Windows10 computers where the "home" directory is called "Users". Please close this PR.