-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links in Instructor Notes #1501
Comments
I filed a sandpaper issue because this is an issue in how links are converted in the build process and though we could manually fix them, a long term more maintainable solution is for this to be fixes in the build tools. A manual workaround is to delete the solo instructor from the path so that:
becomes
We could manually update all of the paths to be the full path of the rendered images for now, but that fix would break again when we move from |
I will make sure to have the next version of {sandpaper} with this fix up next week. I have been a bit underwater coming back to a breaking dependency and a mountain of emails. |
Another solution is to render them as actual images and add extra width attributes to make them smaller: ![Array Math](fig/array-math.png){width="10%"} |
I like the idea of the rendering them small, but then would still want to allow clicking on them to see the full version (though some people may know that you can right click and open images in new tabs, not all will). |
I've pushed a fix in sandpaper 0.11.9 and it should be available widely in about an hour. Once it is updated on https://carpentries.r-universe.dev/sandpaper, you can go to https://github.com/carpentries/instructor-training/actions/workflows/sandpaper-main.yaml to rebuild the lesson to fix the links. |
And I apologise for this taking longer than expected. The last few weeks have thrown a few challenges my way. |
This is now fixed. Thanks @marklcrowe ! |
The Building Skills with Practice episode (https://preview.carpentries.org/instructor-training/instructor/02-practice-learning.html) includes an instructor note with examples of mental models. The links in this note are broken, and give a 403 Forbidden error.
The text was updated successfully, but these errors were encountered: