Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config parameter fail_on_error does not default to false in pull request previews #314

Closed
zkamvar opened this issue Jul 5, 2022 · 0 comments · Fixed by #315
Closed

config parameter fail_on_error does not default to false in pull request previews #314

zkamvar opened this issue Jul 5, 2022 · 0 comments · Fixed by #315

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Jul 5, 2022

In https://github.com/carpentries-incubator/r-tidyverse-4-datasets/runs/7198272825?check_suite_focus=true#step:8:29, the build indicates that fail_on_error: true, but the config.yaml file does not contain the fail_on_error key.

The problem (I believe) is the fact that the variable I'm defining as error is representative of fail_on_error and not error in the R Markdown sense (where error = TRUE means that errors do not cause failures), which makes the code pretty confusing to read:

error <- this_metadata$get()[["fail_on_error"]]
error <- !is.null(error) && !error
if (!error && !quiet) {
cli::cli_alert_info("{.code fail_on_error: true}. Use {.code error=TRUE} in code chunks for demonstrative errors")
}
for (i in seq_along(build_me)) {
build_episode_md(
path = build_me[i],
outdir = outdir,
workdir = outdir,
quiet = quiet,
error = error
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant