Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page assets need absolute, not relative links. #430

Closed
zkamvar opened this issue Apr 5, 2023 · 1 comment · Fixed by #431
Closed

404 page assets need absolute, not relative links. #430

zkamvar opened this issue Apr 5, 2023 · 1 comment · Fixed by #431

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Apr 5, 2023

What I did not realize is that the GitHub server will serve a 404 from the URL that generated the 404. This means that any relative links will be relative to the incorrect page. This is a problem in our most needed cases like https://carpentries.github.io/instructor-training/checkout/index.html

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 5, 2023

The solution was to add list(site = list(root = url)) to the 404 page metadata to modify this part of the base data for pkgdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant