Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and deprecated fct check_ in the README #487

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix typos and deprecated fct check_ in the README #487

merged 2 commits into from
Jul 7, 2023

Conversation

cpauvert
Copy link
Contributor

@cpauvert cpauvert commented Jul 4, 2023

Hello!
thanks for developing and maintaining this package! I spotted a few typos and mentions of the now deprecated function check_lesson, so I made a few changes.
Hope that helps!
Best,

@zkamvar
Copy link
Contributor

zkamvar commented Jul 7, 2023

Thank you for the contribution! There are some failing checks, but those were fixed in #486, so I'm happy to merge this.

@zkamvar zkamvar merged commit 8030c16 into carpentries:main Jul 7, 2023
5 of 12 checks passed
@cpauvert
Copy link
Contributor Author

cpauvert commented Jul 8, 2023

Glad to help! thanks for the hint regarding the failed check!

@cpauvert cpauvert deleted the fix-typos-and-deprecated-fct branch July 8, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants