Make sure root_path() always points to lesson root #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @milanmlft. Note that the windows runs will likely fail, but that's a strange error that we are getting from testthat, so that can be ignored. Would you be able to add your name to the DESCRIPTION and a NEWS item? |
|
Done! Wasn't sure if I had to bump the version as well, so I put the NEWS item under "Development version" |
|
Thank you! Putting it under "Development version" was the correct move. I will merge it once the checks pass. |
|
(with the exception of the windows checks.... I still do not know what testthat is complaining about) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531