Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds fail when ÷ character is formatted as code without syntax highlighting #589

Closed
tobyhodges opened this issue May 27, 2024 · 3 comments

Comments

@tobyhodges
Copy link
Member

(Derived from a report by @knarrff on Slack)

Something catastrophic happens to the lesson build when a ÷ character is included in a page, formatted as code but with no language specified for syntax highlighting.

I created a minimal example at https://github.com/tobyhodges/refactored-sniffle, demonstrating how

```julia
a ÷ b
```

works fine, but

```
a ÷ b
```

causes something bad to happen to the build.
(Not shown, but reproduced on my local system, is that inline code (i.e. enclosed in single backticks) fails without a language class applied, but works fine with e.g. {.julia} added afterwards.)

The GitHub Actions logs on that example repo suggest that the failure happens even before the lesson site starts to be built. I cannot confirm that, but have been able to reproduce the error with a local build of the linked minimal example.

@tobyhodges
Copy link
Member Author

Following up, this seems to be a problem with pkgdown: a second minimal example using pkgdown directly gives the same problem when running pkgdown::build_site().

@zkamvar
Copy link
Contributor

zkamvar commented May 28, 2024

Linking r-lib/downlit#189 so that it's clear where this is being fixed.

@tobyhodges
Copy link
Member Author

The new version of downlit has been released and have confirmed that lesson builds are now succeeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants