Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code colouring and style #103

Merged
merged 2 commits into from Nov 8, 2023
Merged

Fix code colouring and style #103

merged 2 commits into from Nov 8, 2023

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Nov 8, 2023

I ran the sandpaper-docs with 0.3.2 and found that the code blocks are borked:

a code block with striping for each line

That's on me. I reviewed the PRs that went through.

I've fixed this so that the code blocks no longer have that weird striping and so that the inline code is a bit more visible (I got rid of the default boostrap formatting)
a normal code block with a grey background
text with code emphasized and a bit bigger and a different font than the rest of the text

@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 8, 2023

I have confirmed that this works with the integration test, so I will merge and release

@zkamvar zkamvar merged commit fc5a780 into main Nov 8, 2023
1 check passed
@zkamvar zkamvar deleted the fix-code-block-background branch November 8, 2023 18:58
@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 8, 2023

Note: this is not quite right because, while this will correctly transform all bare code (with no class) to use black, it will only transform the code that are directly under <p> elements to have a font size of 1em and a white background color, which does not affect code elements under <li>, <dt> or <dd>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants