Add l10n support #105
Merged
Add l10n support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Footer still needs a lot of work and thinking
Further additions for translation
This will accomodate the awkward back to top text where the "Back" portion will disappear on smaller width screens 🤷
Both Expand/Collapse Solutions and Collapse/Episodes (for the sidebar) had the text hard-coded into the JavaScript, which made implementing translations difficult. Since both of these buttons have binary states, I added the translations as data attributes in the HTML element itself so that the JavaScript could pull from those attributes to insert the proper text.
|
The sandpaper PR has been merged, so I will now merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be paired with carpentries/sandpaper#546.
NOTE: this should be released after carpentries/sandpaper#546
This replaces bare text elements with
{{ translate.Key }}wheretranslate.Keyis a keyword written in PascalCase to the translation variable in {sandpaper}For example, the words "Instructor Notes" have the key
{{ translate.InstructorNotes }}because the data for the mustache template will contain a list called "translate", which will contain an item called "InstructorNotes" containing the translation for "Instructor Notes":We are assuming that these elements will be available, which is why we do not test for them.
There are some elements that contain HTML and are escaped (e.g.
{{& translate.EstimatedTime }}.