Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting problems in instructor training callouts #81

Closed
ndporter opened this issue Feb 28, 2024 · 3 comments
Closed

Formatting problems in instructor training callouts #81

ndporter opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working fixed (awaiting confirmation) {sandpaper} user interface package

Comments

@ndporter
Copy link

Callouts in Instructor Training are displaying in CAPS UNDERLINE for all text (example).

It is not hard-coded that way in the episode and the pattern does not seem to hold for other lessons (I checked Data Carpentry Image Processing and the Maintainer Onboarding).

@froggleston
Copy link

At first glance, this is due to the callout-inner div seeming to have extra CSS properties:

<div class="section level3 callout-title callout-inner">

This should be:

<div class="callout-inner">

I'm unsure why these extra classes are being pulled in. I'll do some digging.

@froggleston
Copy link

froggleston commented Feb 28, 2024

Ah, it looks like a carbon copy of this bug, which is still open: #59

And the rationale behind the issue is exactly the same as described here: carpentries/sandpaper#470

The instructor-training pandoc version seems to be 3.1.11, whereas an example other lesson such as swcarpentry/shell-novice is using 2.19.2: https://github.com/swcarpentry/shell-novice/actions/runs/8057544038/job/22008835053#step:4:3

@ErinBecker
Copy link

Closed with carpentries/sandpaper#574. Screenshot below confirms text of callouts is no longer all caps underline. Thanks @froggleston for the fix and @ndporter (and @brownsarahm for reporting in carpentries/varnish#128).

Screenshot 2024-03-22 at 2 27 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed (awaiting confirmation) {sandpaper} user interface package
Projects
None yet
Development

No branches or pull requests

3 participants