Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use struct with matrix operations instead of raw array #1

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

carrascomj
Copy link
Owner

@carrascomj carrascomj commented Apr 10, 2020

Motivation

In order to use more chained matrix transformations, a better API should be implemented to apply matrix transformations and element wise operations.

Implementation

Change kernel from an alias type to a proper struct with matrix operations.

Progress

  • working locally.
  • tests implemented.
  • implement also Mul for Kernel -> Kernel (not needed for the current transformations).

@carrascomj carrascomj marked this pull request as ready for review April 10, 2020 13:38
@carrascomj carrascomj merged commit 0aafcaa into master Apr 10, 2020
@carrascomj carrascomj deleted the refactor-kernel-struct branch May 26, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant