Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better configuration error #1736

Closed
st0012 opened this issue Sep 9, 2015 · 3 comments
Closed

Better configuration error #1736

st0012 opened this issue Sep 9, 2015 · 3 comments

Comments

@st0012
Copy link
Contributor

st0012 commented Sep 9, 2015

Hello, I noticed that if we configure a not yet registered uploader like:

configure.storage = :foo

It will raise

TypeError: no implicit conversion of nil into String

which is caused by eval in this line

And this is a very confusing message, you have to dive into source code to find out what's wrong. So I wonder if there anyone think raise a custom exception here will be a good idea?

@thomasfedb
Copy link
Contributor

@st0012 Are you able to provide a pull request to improve the error message?

@st0012
Copy link
Contributor Author

st0012 commented Nov 18, 2015

@thomasfedb Sure, I will work on it.

@bensie
Copy link
Member

bensie commented Nov 24, 2015

Closed by #1779

@bensie bensie closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants