Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding strategy change causes sadness with previously uploaded files? #2428

Closed
FeminismIsAwesome opened this issue Oct 17, 2019 · 1 comment

Comments

@FeminismIsAwesome
Copy link

Hello there,
so we have some file copies/uploads that point to stored AWS files and re-upload them to a new activerecord model. I noticed that a file that was previously named Company%2BLogo%2BHuge.png was getting converted to Company+Logo+Huge.png, which then meant it was unable to find the right file on aws with image.remote_image_url = 'Company%2BLogo%2BHuge.png' since it needed it with %2B, not encoded. This worked before on 1.3.1. How do you advise resolving this, given we have older aws files stored with % encoding like that?

tl;dr
image.remote_image_url = 'aws.com/Company%2BLogo%2BHuge.png' used to work, but now it will fail to find the right file since it encodes into + signs. Do we need to make our own downloader that maintains old behavior?

@mshibuya
Copy link
Member

3faf749 should have fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants