Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding slope adjustment 0.0.4.1 #11

Open
carrus2049 opened this issue Jun 17, 2024 · 10 comments
Open

Adding slope adjustment 0.0.4.1 #11

carrus2049 opened this issue Jun 17, 2024 · 10 comments

Comments

@carrus2049
Copy link
Owner

Assumed slope behavior. Known issue is that when prev rate is not zero, the slope adjustment will reset the start of slope to 0, doubt that it's the desired behavior and the formula is kinda tricky.
https://github.com/carrus2049/reaper_SM_tweaker/assets/70931300/8aa5eedf-752e-4981-80d8-fd178f9e8043

@antonjazzsax
Copy link

Oh yeah man. that's exactly what we want to avoid for this use case

@carrus2049
Copy link
Owner Author

Took awhile to figure that out. Plz check if them works as expected! And some minor(I assume) is stated at changelog

@antonjazzsax
Copy link

antonjazzsax commented Jul 4, 2024

Hi. Thanks a lot! Seems to be working properly now. So maybe could be moved on the zoom dependant actions for slope adjustment as well now? I would then test it all together thoroughtly in different scenarios.

@carrus2049
Copy link
Owner Author

Glad to know it's working! zoom deps and two way API is added in 0.0.4.3. Note that step size and zoom lamdba is separated in configs.lua
It's copied from SM API and not tested so as well feel free to post if anything goes wrong!

@antonjazzsax
Copy link

Hi. Thank you very much. Right now testing it.

  1. Can you please add 2 way actions for the slope actions, both absolute and zoom dependant?

  2. I will keep testing the slope behaviour, especially with regards to the issue of slope/stretch state being reset, or adjusted wrongly. It's a bit tricky, as you mentioned earlier. But I will make my observations and will try to suggest the behavior. Thank you.

@carrus2049
Copy link
Owner Author

Hi, I think the two way and zoom dep action is added at here and here ;)

@antonjazzsax
Copy link

Oh. Sorry. Did i miss those? Thanks. I'll test out the rest today then

@antonjazzsax
Copy link

antonjazzsax commented Jul 15, 2024

there is a missing dot in the file name of one of those 2way actions though, which prevented it from loading into reaper. Should be 2way.lua , not 2waylua

@antonjazzsax
Copy link

OK. I've tried out the slope actions now. Here is what worked:
Slope adjusters abs_val forward and backward work ok to the point. What is good is that slope ratio at the end point of the slope matches the stretch ratio (which remain without the slope for the rest of the region on the right from the SM). This is the kind of behavior that should be for the slope actions.

What doesn't work

  1. That same stretch factor , which remains neutral slope-wise for the remaining portion of the region starts going off relative to slope end point ratio (on the left) once the slope has crossed some invisible threshold. I think I understand why it happens and it looks related to the issues bellow.

  2. The region should get longer (due to changed slope and stretch factors) as the slope is being adjusted. Currently it cuts of the portion of the region at the end and one needs to manually pull the missing portion of the region out at the end. Which doesn't work well too because of the issue below.

  3. Basically looks like scripts creates some 'ghost' stretch markers at the end of the region, which in itself is not bad, it is how Stretch markers work in reaper. However, it seems to populate dozens of those 'ghost' stretch markers, which then seem to mess the whole relation between slope end point and the stretch point behind it (as described in issue 1). Also even if the dissapeared region has been retrieved, those numerous ghost stretch markers at the end defeat the purpose, as they completely mess the very end of the region.
    My suggested solution for issues 2,3 would be to try to ensure that:

  • the region end always moves with the stretched region, instead of being swollen out, due to the length of the region being preserved.
  • there is only one 'ghost' marker at the very end and it is the very last thing of that region that moves with the stretch, so that nothing is getting messed up with those numerous auto generated 'ghost' stretch markers. If that is possible.
  1. Zoom dependant actions for slope adjustement don't work in a sense that the right hand portion of the region does not at all follow the stretch factor of the end point of the slope (similar to issue 1).

  2. 2way Actions for slope adjustment (both abs_val and zoom_dependant) don't work as per desired behavior either. The slope gets adjusted, but the stretch factor of the remaining portion of the region on the right does not follow the stretch factor of the slope end point.
    

Hope that description is understandable. If not I can try to screen capture something. Just not used to it .

Please let me know, if it's possible to correct. Thank you

@carrus2049
Copy link
Owner Author

there is a missing dot in the file name of one of those 2way actions though, which prevented it from loading into reaper. Should be 2way.lua , not 2waylua

Ahh my bad for that, I'll take a look into those issues and fix this along the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants