Make sure to fetch all the labels from Github #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Nov 13, 2020
weaverryan
reviewed
Nov 13, 2020
| @@ -75,6 +75,8 @@ services: | |||
|
|
|||
| Github\Api\Issue\Labels: | |||
| factory: ['@Github\Api\Issue', labels] | |||
| calls: | |||
| - ['setPerPage', [100]] | |||
There was a problem hiding this comment.
We're telling the Labels API to return 100 results but we're also using ResultPager to fetch all the results? That seems potentially redundant - are we doing it just to be safe?
There was a problem hiding this comment.
We currently have 87 labels. If we add 14 more this will be a silent error. So yes, the ResultPager is not really needed at the moment.
There was a problem hiding this comment.
Btw, The ResultPager is just making extra requests for us.
If we left this as (default) 20, the Result pager would make 5 request.
weaverryan
force-pushed
the
fetch-all-labels
branch
from
e94ad80
to
1e9b6d7
Compare
|
Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wohoo. I found a bug.
When we asked Github for all the labels on symfony/symfony, we just got the 20 first ones. This PR will fix that.