Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop to a square of [width x width] in the render when height of canvas is grather than width #18

Closed
luispichio opened this issue Mar 6, 2018 · 3 comments

Comments

@luispichio
Copy link

Hi guys!
The function [getTemporaryCanvas] of [Util.js] have a incorrect value asignment: "canvasHeight = originalCanvas.width" <-- here is
This generates a crop to a square of [width x width] in the render when height of canvas is grather than width.
Sorry for my English; See you!

@srkela
Copy link
Collaborator

srkela commented Mar 7, 2018

Hi there, thank you for participating.

I'm sorry I cannot reproduce, can you please explain better this issue? That happens when resize canvas?

Thanks

@luispichio
Copy link
Author

Hi! Thanks for your work :)
Happens in every example when resize (or set it) the working area and the height is greater than width.

2018-03-07 07_50_44-https___carstenschaefer github io_drawerjs_examples_fullscreen_ small

Take a look in function [getTemporaryCanvas] of [Util.js]: There is defined a "temporary" canvas of [width x width] instead of [width x height].
See you!

2018-03-07 08_20_00-drawerjs_util js at master carstenschaefer_drawerjs small

@srkela
Copy link
Collaborator

srkela commented Mar 7, 2018

Thank you for the explanation, it's fixed

@srkela srkela closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants