chore: Upgrade dependencies.

package.json

@@ -5,22 +5,22 @@
   },
   "dependencies": {
     "@phenomnomnominal/tsquery": "^4.0.0",
-    "@typescript-eslint/experimental-utils": "^4.0.0",
-    "eslint-etc": "^4.0.4",
+    "@typescript-eslint/experimental-utils": "^5.0.0",
+    "eslint-etc": "^5.0.0",
     "requireindex": "~1.2.0",
     "tslib": "^2.0.0",
     "tsutils": "^3.0.0"
   },
   "description": "More general-purpose ESLint rules",
   "devDependencies": {
-    "@cartant/eslint-config": "^2.0.0",
+    "@cartant/eslint-config": "^3.0.0",
     "@types/common-tags": "^1.8.0",
     "@types/eslint": "^7.0.0",
     "@types/mocha": "^9.0.0",
     "@types/node": "^16.0.0",
-    "@typescript-eslint/parser": "^4.0.0",
+    "@typescript-eslint/parser": "^5.0.0",
     "common-tags": "^1.8.0",
-    "eslint": "^7.0.0",
+    "eslint": "^8.0.0",
     "husky": "^7.0.0",
     "lint-staged": "^11.0.0",
     "mocha": "^9.0.0",
@@ -29,9 +29,6 @@
     "ts-node": "^10.0.0",
     "typescript": "~4.4.2"
   },
-  "engines": {
-    "node": ">=10"
-  },
   "files": [
     "dist",
     "docs",
@@ -51,8 +48,8 @@
   "name": "eslint-plugin-etc",
   "optionalDependencies": {},
   "peerDependencies": {
-    "eslint": "^5.0.0 || ^6.0.0 || ^ 7.0.0",
-    "typescript": "^3.0.0 || ^4.0.0"
+    "eslint": "^8.0.0",
+    "typescript": "^4.0.0"
   },
   "private": false,
   "publishConfig": {

source/rules/no-assign-mutated-array.ts

@@ -23,11 +23,11 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Possible Errors",
       description: "Forbids the assignment of returned, mutated arrays.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "Assignment of mutated arrays is forbidden.",
     },
@@ -38,23 +38,24 @@ const rule = ruleCreator({
   create: (context) => {
     const { couldBeType } = getTypeServices(context);
     return {
-      [`CallExpression > MemberExpression[property.name=${mutatorRegExp.toString()}]`]: (
-        memberExpression: es.MemberExpression
-      ) => {
-        const callExpression = getParent(memberExpression) as es.CallExpression;
-        const parent = getParent(callExpression);
-        if (parent && !isExpressionStatement(parent)) {
-          if (
-            couldBeType(memberExpression.object, "Array") &&
-            mutatesReferencedArray(callExpression)
-          ) {
-            context.report({
-              messageId: "forbidden",
-              node: memberExpression.property,
-            });
+      [`CallExpression > MemberExpression[property.name=${mutatorRegExp.toString()}]`]:
+        (memberExpression: es.MemberExpression) => {
+          const callExpression = getParent(
+            memberExpression
+          ) as es.CallExpression;
+          const parent = getParent(callExpression);
+          if (parent && !isExpressionStatement(parent)) {
+            if (
+              couldBeType(memberExpression.object, "Array") &&
+              mutatesReferencedArray(callExpression)
+            ) {
+              context.report({
+                messageId: "forbidden",
+                node: memberExpression.property,
+              });
+            }
           }
-        }
-      },
+        },
     };
 
     function isNewArray(node: es.LeftHandSideExpression): boolean {

source/rules/no-commented-out-code.ts

@@ -10,11 +10,11 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids commented-out code.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "Commented-out code is forbidden.",
     },

source/rules/no-const-enum.ts

@@ -17,11 +17,11 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids the use of `const enum`.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "`const enum` is forbidden.",
     },

source/rules/no-deprecated.ts

@@ -20,11 +20,11 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids the use of deprecated APIs.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: `"{{name}}" is deprecated: {{comment}}`,
     },

source/rules/no-enum.ts

@@ -12,11 +12,11 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids the use of `enum`.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "`enum` is forbidden.",
     },

source/rules/no-foreach.ts

@@ -15,11 +15,11 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids calling `forEach`.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "Calling `forEach` is forbidden.",
     },

source/rules/no-implicit-any-catch.ts

@@ -41,13 +41,13 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Possible Errors",
       description:
         "Forbids implicit `any` error parameters in promise rejections.",
       recommended: false,
       suggestion: true,
     },
     fixable: "code",
+    hasSuggestions: true,
     messages: {
       explicitAny: "Explicit `any` in promise rejection.",
       implicitAny: "Implicit `any` in promise rejection.",

source/rules/no-internal.ts

@@ -22,11 +22,11 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids the use of internal APIs.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: `"{{name}}" is internal.`,
     },

source/rules/no-misused-generics.ts

@@ -15,12 +15,12 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description:
         "Forbids type parameters without inference sites and type parameters that don't add type safety to declarations.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       canReplace:
         "Type parameter '{{name}}' is not used to enforce a constraint between types and can be replaced with '{{replacement}}'.",

source/rules/no-t.ts

@@ -14,11 +14,11 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids single-character type parameters.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: `Single-character type parameters are forbidden. Choose a more descriptive name for "{{name}}"`,
       prefix: `Type parameter "{{name}}" does not have prefix "{{prefix}}"`,

source/rules/prefer-interface.ts

@@ -27,11 +27,11 @@ const rule = ruleCreator({
   defaultOptions: defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids type aliases where interfaces can be used.",
       recommended: false,
     },
     fixable: "code",
+    hasSuggestions: true,
     messages: {
       forbidden: "Type can be declared using an interface.",
       suggest: "Use an interface instead of a type alias.",
@@ -48,9 +48,8 @@ const rule = ruleCreator({
   },
   name: "prefer-interface",
   create: (context, unused: typeof defaultOptions) => {
-    const [
-      { allowIntersection = true, allowLocal = false } = {},
-    ] = context.options;
+    const [{ allowIntersection = true, allowLocal = false } = {}] =
+      context.options;
 
     function formatTypeParameters(
       typeParameters?:

source/rules/prefer-less-than.ts

@@ -13,11 +13,11 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids greater-than comparisons.",
       recommended: false,
     },
     fixable: "code",
+    hasSuggestions: true,
     messages: {
       forbiddenGT: "Greater-than comparisons are forbidden.",
       forbiddenGTE: "Greater-than-or-equal comparisons are forbidden.",

source/rules/throw-error.ts

@@ -11,11 +11,11 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description: "Forbids throwing - or rejecting with - non-`Error` values.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "{{usage}} non-`Error` values is forbidden.",
     },
@@ -49,27 +49,26 @@ const rule = ruleCreator({
         }
         checkRejection(getParent(node) as es.CallExpression);
       },
-      "NewExpression[callee.name='Promise'] > ArrowFunctionExpression, NewExpression[callee.name='Promise'] > FunctionExpression": (
-        node: es.ArrowFunctionExpression | es.FunctionExpression
-      ) => {
-        const [, param] = node.params;
-        if (!param) {
-          return;
-        }
-        const text = sourceCode.getText(param);
-        const variable = context
-          .getDeclaredVariables(node)
-          .find((variable) => variable.name === text);
-        if (!variable) {
-          return;
-        }
-        variable.references.forEach(({ identifier }) => {
-          const parent = getParent(identifier) as es.Node;
-          if (isCallExpression(parent) && identifier === parent.callee) {
-            checkRejection(parent);
+      "NewExpression[callee.name='Promise'] > ArrowFunctionExpression, NewExpression[callee.name='Promise'] > FunctionExpression":
+        (node: es.ArrowFunctionExpression | es.FunctionExpression) => {
+          const [, param] = node.params;
+          if (!param) {
+            return;
           }
-        });
-      },
+          const text = sourceCode.getText(param);
+          const variable = context
+            .getDeclaredVariables(node)
+            .find((variable) => variable.name === text);
+          if (!variable) {
+            return;
+          }
+          variable.references.forEach(({ identifier }) => {
+            const parent = getParent(identifier) as es.Node;
+            if (isCallExpression(parent) && identifier === parent.callee) {
+              checkRejection(parent);
+            }
+          });
+        },
       ThrowStatement: (node: es.ThrowStatement) => {
         if (
           node.argument &&

source/rules/underscore-internal.ts

@@ -13,12 +13,12 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description:
         "Forbids internal APIs that are not prefixed with underscores.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden: "Internal APIs not prefixed with underscores are forbidden.",
     },
@@ -45,7 +45,7 @@ const rule = ruleCreator({
           checkDeclaration(node.id, esTreeNodeToTSNodeMap.get(node));
         }
       },
-      "ClassProperty[key.name=/^[^_]/]": (node: es.ClassProperty) => {
+      "PropertyDefinition[key.name=/^[^_]/]": (node: es.PropertyDefinition) => {
         if (isIdentifier(node.key)) {
           checkDeclaration(node.key, esTreeNodeToTSNodeMap.get(node));
         }