Use strict equality check by default (#68)

* test: Add failing test case. * fix: Use strict equality comparison by default.
cartant · Feb 11, 2020 · c12ce82 · c12ce82 · iamchangming · Mar 25, 2020
1 parent 75b646c
commit c12ce82
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/fixtures/jest/failing-spec.ts b/fixtures/jest/failing-spec.ts
@@ -29,6 +29,23 @@ if (process.env.FAILING !== "0") {
         m.expect(source).toHaveSubscriptions(subs);
       })
     );
+
+    test(
+      "it should fail the strict comparison check when excess properties are present",
+      marbles(m => {
+        interface Person {
+          name: string;
+          age?: number;
+        }
+
+        const source = m.cold<Person>("a-", {
+          a: { name: "Bob", age: undefined }
+        });
+        const expected = m.cold<Person>("a-", { a: { name: "Bob" } });
+
+        m.expect(source).toBeObservable(expected);
+      })
+    );
   });
 
   describe("observe", () => {

diff --git a/source/jest/index.ts b/source/jest/index.ts
@@ -40,7 +40,7 @@ export function configure(
 } {
   const { marbles } = _configure({
     ...configuration,
-    assertDeepEqual: (a, e) => expect(a).toEqual(e),
+    assertDeepEqual: (a, e) => expect(a).toStrictEqual(e),
     frameworkMatcher: true
   });
 
@@ -66,7 +66,10 @@ export function configure(
             )
           );
         } else {
-          t(c.name, marbles((m, ...rest: any[]) => func(m, c, ...rest)));
+          t(
+            c.name,
+            marbles((m, ...rest: any[]) => func(m, c, ...rest))
+          );
         }
       }, cases);
     });