Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxjs-no-patched toPromise must not emit error #12

Closed
Delagen opened this issue Oct 6, 2017 · 2 comments
Closed

rxjs-no-patched toPromise must not emit error #12

Delagen opened this issue Oct 6, 2017 · 2 comments
Labels

Comments

@Delagen
Copy link

Delagen commented Oct 6, 2017

toPromise is now base method of Observable due 5.5.0-beta.5

@cartant
Copy link
Owner

cartant commented Oct 6, 2017

Wow, you were super fast raising that! Congratulations.

I'll have a think about the best way of fixing this. It should be possible to sniff the RxJS version, as the rules already resolve RxJS to its node_modules location to read the files in the add/operator directory, etc. Reading the version from the package.json should be simple enough.

In the interim, I guess that's life on the bleeding edge.

@cartant cartant added the bug label Oct 6, 2017
@cartant
Copy link
Owner

cartant commented Oct 6, 2017

Should be fixed in 3.0.2. Re-open if otherwise.

@cartant cartant closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants