Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib is a dependency, but is not listed in package.json #18

Closed
jdell64 opened this issue Nov 16, 2017 · 1 comment
Closed

tslib is a dependency, but is not listed in package.json #18

jdell64 opened this issue Nov 16, 2017 · 1 comment

Comments

@jdell64
Copy link

jdell64 commented Nov 16, 2017

I was working on an angular project using @angular/animations which has a dependency on tslib: ^1.7.1 which produces the following error when running the linter rules:

tslib_1.__makeTemplateObject is not a function
TypeError: tslib_1.__makeTemplateObject is not a function
    at /myproject/node_modules/rxjs-tslint-rules/dist/rules/rxjsAddRule.js:27:95
    at Object.<anonymous> (/myproject/node_modules/rxjs-tslint-rules/dist/rules/rxjsAddRule.js:35:2)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at loadRule (/myproject/node_modules/tslint/lib/ruleLoader.js:96:26)

This was resolved by removing node_modules/tslib and rerunning npm install which pulled down tslib 1.8.0 as a dependency of @angular/animations.

package.json for rxjs-tslint-rules doesn't list tslib as a dependency but it looks like it is. It should probably be added with the minimum version of 1.8.0.

@cartant
Copy link
Owner

cartant commented Nov 16, 2017

Thanks. Fixed in 3.1.1.

@cartant cartant closed this as completed Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants