Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#166 Add e2e tests for navigation #167

Merged
merged 9 commits into from
May 30, 2024
Merged

#166 Add e2e tests for navigation #167

merged 9 commits into from
May 30, 2024

Conversation

nevendyulgerov
Copy link
Contributor

I added e2e tests for the navigation.

@nevendyulgerov nevendyulgerov self-assigned this Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:22am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:22am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:22am

@nevendyulgerov nevendyulgerov marked this pull request as ready for review April 30, 2024 07:12
@nevendyulgerov nevendyulgerov linked an issue Apr 30, 2024 that may be closed by this pull request
Add test cases for the Navigation menu. #166
Closed
5 tasks
dandheedge
dandheedge requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@dandheedge dandheedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also

rollups-explorer/apps/web/e2e/menu.spec.ts

Line 153 in a23c34e

page.getByPlaceholder("Search by Address / Txn Hash / Index"),

apps/web/e2e/menu.spec.ts Outdated Show resolved Hide resolved
@nevendyulgerov nevendyulgerov force-pushed the feature/166-add-e2e-tests-for-navigation branch from e652f66 to 4f57bb9 Compare May 4, 2024 06:58
@dandheedge
Copy link
Contributor

@nevendyulgerov LGTM, only need some rebase on apps/web/src/app/applications/page.tsx and we can merge it

@nevendyulgerov nevendyulgerov force-pushed the feature/166-add-e2e-tests-for-navigation branch from 988b975 to 2a6ae50 Compare May 8, 2024 07:12
@brunomenezes brunomenezes merged commit adc62bb into main May 30, 2024
8 checks passed
@brunomenezes brunomenezes deleted the feature/166-add-e2e-tests-for-navigation branch May 30, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
apps: web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test cases for the Navigation menu.
3 participants
@nevendyulgerov @dandheedge @brunomenezes