s2.latLngToKey is not publicly accessible

[mentin]

I can run SELECT jslibs.h3.ST_H3(st_geogpoint(1,2),7),
but SELECT jslibs.s2.latLngToKey(1,2,3) gives me

Access Denied: Routine jslibs:s2.latLngToKey: The user ...@... does not have permission to invoke routine jslibs.s2.latLngToKey.

[jatorre]

Yep, sorry did not have time to bundle correctly the S2 library, is there, but not bundled

[mentin]

Permissions seems to be OK now, but I'm now getting

SELECT jslibs.s2.latLngToKey(1,2,3)

ReferenceError: window is not defined at gs://bigquery-jslibs/s2geometry.js line 594, columns 52-53

[jatorre]

Yeah. Still need to be processed to remove the window part. Will get into it ASAP

On Tue, 5 Nov 2019 at 22:45, Michael Entin ***@***.***> wrote: Permissions seems to be OK now, but I'm now getting SELECT jslibs.s2.latLngToKey(1,2,3) ReferenceError: window is not defined at gs://bigquery-jslibs/s2geometry.js line 594, columns 52-53 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7GO3OIBVM7ACPWDH53PLQSHSQHANCNFSM4IQHCB2A> .

-- *Javier de la Torre* Chief Strategy Officer | jatorre@carto.com <https://www.carto.com/>

[JacobHayes]

Hi @jatorre have you had a chance to take a look at this? If not, could you point me to what I'd need to do? I'd be happy to PR it. It's obviously due to this line referencing an undefined window in the false case of the condition, but not sure exactly what it should reference instead.

[jatorre]

No, haven’t looked at it. The work to be done is to bundle the s2 js library in a window less, like if it was a nodejs library and then add the methods. I think I used browserify with other libraries but I am not an expert on packaging JS libraries and always have to try multiple things.

On Fri, 31 Jan 2020 at 00:30, Jacob Hayes ***@***.***> wrote: Hi @jatorre <https://github.com/jatorre> have you had a chance to take a look at this? If not, could you point me to what I'd need to do? I'd be happy to PR it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7GOZ4XBWUQ2SU3HHTAIDRANPJZANCNFSM4IQHCB2A> .

-- *Javier de la Torre* Chief Strategy Officer +34 911 165 823 | jatorre@carto.com [image: Spatial Data Science Ebook] <https://go.carto.com/ebooks/spatial-data-science>

[XavierLavenir]

Are there any plans to implement this soon? Would be really useful

[jatorre]

It should be possible now thanks to @francois-baptiste and there are a few other options