Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external links should open a new tab #55

Closed
aaronshurley opened this issue Feb 20, 2021 · 1 comment
Closed

external links should open a new tab #55

aaronshurley opened this issue Feb 20, 2021 · 1 comment

Comments

@aaronshurley
Copy link
Contributor

Why

We want to create a consistent experience for visitors to carvel.dev. Currently, we have external links (e.g. link to GitHub repo) that follow those link within the current tab creating a disjointed experience of our website and losing the "reminder" to continue on the website. To fix this, we would like to have all external links open a new tab.

As a carvel.dev visitor
I want external links to open in new tabs
So that I can preserve the carvel.dev experience and be reminded to browse the website further.

Acceptance Criteria

Given the website is updated
When I click an external link (i.e. a link that directs a visitor away from the website)
Then I am directed to that link in a new tab.

Notes

@aaronshurley
Copy link
Contributor Author

Thank you @kayvee83 for the PR!

@github-actions github-actions bot added carvel triage This issue has not yet been reviewed for validity and removed carvel triage This issue has not yet been reviewed for validity labels Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant