Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kapp: Docs for resource matchers imply they're only used by rebaseRules and ownershipLabelRules #76

Closed
gabegorelick opened this issue Mar 26, 2021 · 3 comments
Closed

kapp: Docs for resource matchers imply they're only used by rebaseRules and ownershipLabelRules #76

gabegorelick opened this issue Mar 26, 2021 · 3 comments
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered

Comments

@gabegorelick
Copy link

Resource matchers are used by rebaseRules, ownershipLabelRules, waitRules, and probably other rules, but only the first two are mentioned under the "Resource matchers" section.

https://carvel.dev/kapp/docs/latest/config/#resource-matchers

Resource matchers (as used by rebaseRules and ownershipLabelRules):

image
@gabegorelick gabegorelick added the carvel triage This issue has not yet been reviewed for validity label Mar 26, 2021
@gabegorelick gabegorelick changed the title Docs for resource matchers imply they're only used by rebaseRules and ownershipLabelRules kapp: Docs for resource matchers imply they're only used by rebaseRules and ownershipLabelRules Mar 26, 2021
@gcheadle-vmware
Copy link
Contributor

Hi @gabegorelick, great call out! You are absolutely correct, resourceMatchers are used in every kapp config rule expect for additionalLabels. We can make a PR to reflect this information in the kapp docs (we are also accepting contributions from the community).
Thank you for pointing this out!

@gcheadle-vmware gcheadle-vmware added carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered and removed carvel triage This issue has not yet been reviewed for validity labels Mar 29, 2021
@gcheadle-vmware gcheadle-vmware mentioned this issue Mar 29, 2021
Merged
@gcheadle-vmware
Copy link
Contributor

PR created, please submit a review on the PR #80 if you have any feedback :)

@gcheadle-vmware
Copy link
Contributor

PR merged on carvel.dev.

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Apr 7, 2021
@cari-lynn cari-lynn removed the carvel triage This issue has not yet been reviewed for validity label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabegorelick @cari-lynn @gcheadle-vmware