Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretTemplate's type cannot be updated #72

Open
Samze opened this issue Jun 1, 2022 · 1 comment
Open

SecretTemplate's type cannot be updated #72

Samze opened this issue Jun 1, 2022 · 1 comment
Labels
awaiting-input carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@Samze
Copy link
Contributor

Samze commented Jun 1, 2022

Describe the problem/challenge you have

#66 Introduced the SecretTemplate API. This allows you to define arbitrary input resources that are used to generate a new Kubernetes Secret based on templating.

One of the fields that is available for templating within the Secret is type. Given this field is immutable the question is what should happen if this value changes within the template.

This could change if someone updates the SecretTemplate type field directly .eg. type: foo to type: bar or if they are using templating and the field changes. e.g. type: $(.resource.data.foo).

The current behaviour is that SecretTemplate attempts to update the Secret but fails. A user will have to delete and recreate the SecretTemplate to get the new value.

Describe the solution you'd like
This may not be a huge issue as it's fairly unlikely that type will be a dynamic field. However if someone typos the type field being able to simply update the template would be nice.

So for changes to type we should consider deleting and re-creating the entire secret.

Anything else you would like to add:
More context in this comment #66 (comment)


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you would like to work on this issue.

@Samze Samze added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jun 1, 2022
@neil-hickey
Copy link
Contributor

Hey @Samze any idea if you have a priority idea on this issue? Or shall I just leave it open until it might get picked up at some point in the future?

@neil-hickey neil-hickey added carvel-accepted This issue should be considered for future work and that the triage process has been completed awaiting-input and removed carvel-triage This issue has not yet been reviewed for validity labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-input carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Status: Unprioritized
Development

No branches or pull requests

2 participants