Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run sync for stable versions, if vendir.yaml has changed since last sync #278

Closed
fritzduchardt opened this issue Aug 7, 2023 · 4 comments · Fixed by #279
Closed
Labels
carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request stale This issue has had no activity for a while and will be closed soon

Comments

@fritzduchardt
Copy link
Contributor

Describe the problem/challenge you have

We have a rollout mechanism that heavily relies on vendir to pull in upstream workloads from Helm Charts, OCI Images and Git Repositories. Most of these workloads have fixed versions and don't change unless their corresponding vendir.yaml is modified. Yet, currently vendir constrains us to sync everything on every run, which slows down the process unnecessarily.

Describe the solution you'd like

We would benefit from a feature that runs sync only, if the vendir.yaml was changed after the last sync. We would activate this feature for all workloads with stable versions.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@fritzduchardt fritzduchardt added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Aug 7, 2023
@kumaritanushree
Copy link
Contributor

@fritzduchardt isn't it similar to this issue #274 (comment) ? Any specific reason for having two separate issues?

@fritzduchardt
Copy link
Contributor Author

Hi @kumaritanushree, it is referring to the same issue, I accidentally created it twice - sorry about that. Shall we close #274

@kumaritanushree
Copy link
Contributor

@fritzduchardt sure, add this issue link there and mention the reason and can close #274
Thank you

@github-actions
Copy link

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request stale This issue has had no activity for a while and will be closed soon
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants