Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendir directory sync ignores overlapping paths on directories #323

Closed
fritzduchardt opened this issue Nov 12, 2023 · 3 comments
Closed
Labels
bug This issue describes a defect or unexpected behavior discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution

Comments

@fritzduchardt
Copy link
Contributor

What steps did you take:
I am running this vendir.yml with two directories that define the same root path:

kind: Config
directories:
- path: vendor
  contents:
  - path: dir1/output
    directory:
      path: ./local-dir
- path: vendor
  contents:
  - path: dir2/output
    directory:
      path: ./local-dir-2

What happened:
The second directory overwrites the first in the final output directory. Only dir2 appears in the final output directory.

What did you expect:
I would either expect an overlapping path error message, as with overlapping paths within the same directory, or I would expect both dirs to appear in the final output directory.

Environment:

  • vendir version: 0.37.0
  • Ubuntu 20.04

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@fritzduchardt fritzduchardt added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Nov 12, 2023
Copy link

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Dec 23, 2023
@renuy renuy reopened this Jan 9, 2024
@renuy renuy added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed stale This issue has had no activity for a while and will be closed soon carvel-triage This issue has not yet been reviewed for validity labels Jan 9, 2024
@renuy
Copy link

renuy commented Jan 9, 2024

Another PR has been added for resolving similar issue #343
This needs discussion to decide on the approach.
To be discussed in community meeting 1/10/2024

@kumaritanushree
Copy link
Contributor

Fix has been done as part of PR #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants