Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken 'ytt website' in Windows v0.35.0 #456

Closed
wezzman opened this issue Jul 11, 2021 · 3 comments
Closed

Broken 'ytt website' in Windows v0.35.0 #456

wezzman opened this issue Jul 11, 2021 · 3 comments
Labels
bug This issue describes a defect or unexpected behavior

Comments

@wezzman
Copy link

wezzman commented Jul 11, 2021

What steps did you take:
I attempted to run ytt website both with and without --redirect-to-https=false and the default --listen-addr.

What happened:
localhost:8080 shows a completely blank screen with no indication that the connection timed out.

Anything else you would like to add:
The v0.34.0 release correctly displays the playground on the same machine.

I believe that the playground was simply left out of the v0.35.0 package.

I have not confirmed, but I suspect the same issue applies to the Linux and Darwin packages as well. There was a consistent 0.6M drop in file size between v0.34.0 and v0.35.0 for all packages.

Environment:

  • ytt version (use ytt --version): v0.35.0
  • OS (e.g. from /etc/os-release): Windows 10
@wezzman wezzman added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been triaged for relevance labels Jul 11, 2021
@cari-lynn
Copy link
Contributor

Hey @wezzman thanks for bringing this to our attention! It's now fixed for the v0.35.0 release.

This was a bug from the new github workflow to automate the release process. Turns out the step which generates the website content for pkg/website/generated.go in the /hack/build.sh script was left out of the release workflow.

Thanks again, this will be fixed before the next release goes out.

@cari-lynn cari-lynn removed the carvel triage This issue has not yet been triaged for relevance label Jul 12, 2021
@wezzman
Copy link
Author

wezzman commented Jul 12, 2021

I can confirm that ytt website works in the fixed v0.35.0 package, although it appears to be the v0.34.0 playground and lacks the "schema" examples from the hosted playground (aka https://carvel.dev/ytt/#playground).

I don't think the older playground is much of an issue. From my perspective, the main use of the playground is as a nice interactive debugger and development tool. Feel free to close this at your leisure.

@cari-lynn
Copy link
Contributor

Thanks for all your help with this! We have published a patch release v0.35.1 to address this bug. This is the release we recommend is used. Thank you for being patient with us as we iron out our release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants