Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TailCurve argument validation #414

Merged
merged 2 commits into from Jan 24, 2023
Merged

TailCurve argument validation #414

merged 2 commits into from Jan 24, 2023

Conversation

genedan
Copy link
Contributor

@genedan genedan commented Jan 24, 2023

Addresses #413.

@codecov-commenter
Copy link

Codecov Report

Base: 83.92% // Head: 83.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8eb21ec) compared to base (083a2bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   83.92%   83.93%   +0.01%     
==========================================
  Files          50       50              
  Lines        4448     4452       +4     
  Branches      729      731       +2     
==========================================
+ Hits         3733     3737       +4     
  Misses        513      513              
  Partials      202      202              
Flag Coverage Δ
unittests 83.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chainladder/tails/curve.py 60.41% <100.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jbogaardt
Copy link
Collaborator

Thank you @genedan. No doubt this was needed. Error handling in chainladder-python has received limited focus, so I expect similar low hanging fruit exists elsewhere too. Thanks for the PR!

@jbogaardt jbogaardt merged commit 42132f2 into casact:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants