Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add this apisix-authz middleware to the official list #5

Closed
hsluoyz opened this issue Jul 23, 2021 · 8 comments
Closed

Add this apisix-authz middleware to the official list #5

hsluoyz opened this issue Jul 23, 2021 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Jul 23, 2021

See docs: https://apisix.apache.org/docs/apisix/plugins/wolf-rbac

Source code for the docs: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/wolf-rbac.md

We may name it to "casbin-authz"

@hsluoyz hsluoyz self-assigned this Jul 23, 2021
@hsluoyz hsluoyz added the documentation Improvements or additions to documentation label Jul 23, 2021
@hsluoyz
Copy link
Member Author

hsluoyz commented Jul 23, 2021

@rushitote

@rushitote
Copy link
Member

@hsluoyz Sure, I will first add the core API functions like add/remove/update/has/get - policy and grouping policy to this plugin. And then we will also need to update the Casbin module on LuaRocks with the latest rockspec (v1.16.1) so that we can include it as a dependency for other LuaRocks modules.

@hsluoyz
Copy link
Member Author

hsluoyz commented Jul 23, 2021

@rushitote is there a way to setup an auto-release to LuaRocks (like semantic-release)?

@rushitote
Copy link
Member

@hsluoyz I will try to setup one.

@rushitote
Copy link
Member

Opened an initial issue at #4674.

@hsluoyz
Copy link
Member Author

hsluoyz commented Aug 6, 2021

@rushitote kudos! Great work for making Casbin into Apisix! From what I see in: https://github.com/apache/apisix/pull/4710/files , the source code of this repo is already merged into apisix's code base. So do we still need this repo here?

@rushitote
Copy link
Member

@hsluoyz Thanks, and yes this repo is no longer required.

@hsluoyz
Copy link
Member Author

hsluoyz commented Aug 6, 2021

Done by: apache/apisix#4710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants