Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for this project #2

Closed
9 tasks done
xcaptain opened this issue Jul 14, 2019 · 15 comments
Closed
9 tasks done

Roadmap for this project #2

xcaptain opened this issue Jul 14, 2019 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@xcaptain
Copy link
Collaborator

xcaptain commented Jul 14, 2019

This project is still under development, but basic RBAC functions have been tested on my own
projects, but still a lot of things need to be done, includes:

I'm a little busy in the day time but would try to optimize this project

@xcaptain xcaptain self-assigned this Jul 14, 2019
@samchenws
Copy link
Contributor

I've implemented some of the code and I pull requests.

@xcaptain
Copy link
Collaborator Author

@samchenws thanks for the help :)

@hsluoyz
Copy link
Member

hsluoyz commented Jul 18, 2019

Hi @xcaptain , another task is the CI and code coverage, and the badges like this:

image

@xcaptain
Copy link
Collaborator Author

@hsluoyz Sorry for the late reply, I was planning to try out the new github package registry to publish this package but I has beed added to waitlist, so I changed to nuget.org. now the package has been published at https://www.nuget.org/packages/Casbin.NET.Adapter.EFCore/

image

do you have any thought about the package name? or do you think we should publish this package using the official Casbin account?

I'm now going to setup the CI/CD config and finally use travis to publish this package to nuget when a new tag was created.

@hsluoyz
Copy link
Member

hsluoyz commented Jul 29, 2019

Hi @xcaptain , thanks for the contribution. We should publish the package within Casbin account. I have added you, it's pending.

image

@hsluoyz
Copy link
Member

hsluoyz commented Jul 31, 2019

Hi @xcaptain ,

do you have any thought about the package name? or do you think we should publish this package using the official Casbin account?

I'm not very familiar with C#. I think your name Casbin.NET.Adaprer.EFCore has followed the naming convention for .NET projects. Please use the Casbin organization account to publish it.

I'm now going to setup the CI/CD config and finally use travis to publish this package to nuget when a new tag was created.

But before publishing to nuget, you may want to fix the code coverage badge. Currently, the Travis script doesn't send code coverage report to coveralls.

image

@xcaptain
Copy link
Collaborator Author

xcaptain commented Aug 1, 2019

@hsluoyz Thanks for setting travis and codecov,
Can you login into https://www.nuget.org/account/apikeys using the official casbin account and create an apikey for travis to publish package? I have a personal account but I think it's not very appropriate to use my account to publish this package, after all I don't own this project.

image

After that you need to create an travis environment variable using this key

image

The key name should be TRAVIS_CASBIN_NUGET_KEY, it's defined in .travis.yml and then I think travis will be ready to do the publish work.

As for the coverall setup, I need some time to learn, never done any code coverage work for dotnet project before.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 1, 2019

@xcaptain , you are the Administrator for nuget's Casbin org. I think you do it by yourself :)

@hsluoyz
Copy link
Member

hsluoyz commented Aug 3, 2019

@xcaptain can you join our QQ group? https://casbin.org/en/help

@hsluoyz
Copy link
Member

hsluoyz commented Dec 26, 2019

@xcaptain @huazhikui can we develop another adapter for EF?

@AaqibAhamed
Copy link

AaqibAhamed commented Apr 30, 2020

This project is still under development, but basic RBAC functions have been tested on my own
projects, but still a lot of things need to be done, includes:

I'm a little busy in the day time but would try to optimize this project

Update to .NET Core and EFCore 3.1 #12 .This issue #12 has been sorted.

@AaqibAhamed
Copy link

@xcaptain @hsluoyz
Please update the Roadmap for completed tasks and close completed issues.

@xcaptain
Copy link
Collaborator Author

xcaptain commented May 2, 2020

Thanks, updated now.

@hsluoyz
Copy link
Member

hsluoyz commented Jun 6, 2020

@xcaptain can you update the completed items?

@xcaptain
Copy link
Collaborator Author

xcaptain commented Jun 6, 2020

@hsluoyz Updated, seems like the last remaining task is the code coverage.

@hsluoyz hsluoyz closed this as completed Jun 7, 2020
@hsluoyz hsluoyz added the enhancement New feature or request label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants