Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique namespace specification #120

Closed
sagilio opened this issue Jan 31, 2021 · 2 comments · Fixed by #121
Closed

Unique namespace specification #120

sagilio opened this issue Jan 31, 2021 · 2 comments · Fixed by #121
Assignees
Labels
breaking change This issue will incude some breaking changes enhancement Enhancement the exist feature
Milestone

Comments

@sagilio
Copy link
Member

sagilio commented Jan 31, 2021

A improvement in #101.

Description

Casbin has many extensions and it will more in the future, To avoid chaos we can provide a unique namespace specification suggestion. It will like this :

Core Abstractions => Casbin

Sample:

  • "IEnforcer" full type are Casbin.IEnforcer.
  • "IModel" full type are Casbin.IModel
Core => Casbin.[Part Name]

Sample:

  • "Assertion" full type is Casbin.Model.Assertion.
  • "DefaultConfig" full type are Casbin.Config.DefaultConfig
Extensions Abstractions => Casbin.Persist

Sample: "IAdapter" full type is Casbin.Persist.IAdapter

Extensions => Casbin.[Extension Type Name].[Extension Name]

Sample: "EFCoreAdapter" full type are Casbin.Adapter.EFCore.EFCoreAdapter
Sample: "RaftDispatcher" full type are Casbin.Dispatcher.Raft.RaftDispatcher

Changes

Namespace changed (Breaking Changes):

  • NetCasbin.X => Casbin.X
  • Casbin.NET.Adapter.EFCore => Casbin.Adapter.EFCore
@sagilio sagilio mentioned this issue Jan 31, 2021
15 tasks
@sagilio sagilio self-assigned this Jan 31, 2021
@sagilio sagilio added breaking change This issue will incude some breaking changes enhancement Enhancement the exist feature labels Jan 31, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Feb 1, 2021

sounds great to me!

@hsluoyz
Copy link
Member

hsluoyz commented Feb 8, 2021

Fixed by: #121

@hsluoyz hsluoyz closed this as completed Feb 8, 2021
@sagilio sagilio added this to the v2.0.0 milestone Jun 22, 2021
@sagilio sagilio linked a pull request Jun 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue will incude some breaking changes enhancement Enhancement the exist feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants