feat: Add globMatch as a global built-in matcher function #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagilio
changed the title
|
LGTM, please fix here errors You only need to change the message and add the git commit -s --amend -m "feat: Add globMatch as a global built-in matcher function" |
|
@dviry plz fix:
|
|
@hsluoyz Not sure how am I supposed to fix that when all tests completed successfully and the error message states: |
added 2 commits
November 23, 2021 15:01
Signed-off-by: Leon Segal <leon.segal@hs-soft.com>
…in.NET into feature/231-globMatch Signed-off-by: Leon Segal <leon.segal@hs-soft.com>
dviry
force-pushed
the
feature/231-globMatch
branch
from
5206193
to
38fa500
Compare
|
@Leonardo-Ferreira @sagilio can you resolve the Sonar error? |
We can skip sonar on PR |
|
@sagilio @xcaptain @huazhikui please review |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #231
Implemented as a global built-in function and added related unit tests.