Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change to Microsoft.Extensions.Configuration.Ini resolution .conf #332

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

Tanyuu
Copy link
Contributor

@Tanyuu Tanyuu commented Aug 31, 2023

Since the library can't handle newlines and comments, the ParseStringInit method processes the string first and then feeds it into ParseBuffer. in addition, since the library doesn't support net452, it retains the old parse method.

Fix: #264

Signed-off-by: Tan <2912363476@qq.com>
Signed-off-by: Tan <2912363476@qq.com>
@casbin-bot
Copy link
Member

@sagilio please review

@hsluoyz
Copy link
Member

hsluoyz commented Aug 31, 2023

@sagilio

Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
@sagilio sagilio self-assigned this Sep 10, 2023
@sagilio sagilio added the enhancement Enhancement the exist feature label Sep 10, 2023
Signed-off-by: Tan <2912363476@qq.com>
@Tanyuu Tanyuu requested a review from sagilio September 11, 2023 01:26
@hsluoyz
Copy link
Member

hsluoyz commented Sep 11, 2023

@sagilio plz review

Casbin/Casbin.csproj Outdated Show resolved Hide resolved
Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
Casbin/Config/DefaultConfig.cs Outdated Show resolved Hide resolved
Signed-off-by: Tan <2912363476@qq.com>
@sagilio sagilio self-requested a review September 16, 2023 12:06
Copy link
Member

@sagilio sagilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagilio sagilio merged commit 0e56748 into casbin:master Sep 16, 2023
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement the exist feature released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use exist well-established configurion parser
4 participants