Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the workflow of creating a model #52

Closed
sagilio opened this issue Jul 18, 2020 · 1 comment · Fixed by #70
Closed

Change the workflow of creating a model #52

sagilio opened this issue Jul 18, 2020 · 1 comment · Fixed by #70
Assignees
@sagilio
Labels
enhancement Enhancement the exist feature
Milestone
v2.0.0

Comments

@sagilio
Copy link
Member

sagilio commented Jul 18, 2020 •
edited

I think we should move the NewModel API to Model class. It will follow the go implement.
It will be some break changes if we directly delete them, So we can set Obsolete at on them now and remove at the next mainline version.
@sagilio sagilio added the enhancement Enhancement the exist feature label Jul 21, 2020
@sagilio sagilio self-assigned this Jul 21, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Jul 25, 2020

@sagilio yes, please follow the Go's Casbin way.

@sagilio sagilio mentioned this issue Aug 5, 2020
Merged
@sagilio sagilio mentioned this issue Oct 8, 2020
Closed
15 tasks
@sagilio sagilio added this to the v2.0.0 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagilio sagilio

Labels
enhancement Enhancement the exist feature
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Change the workflow of creating a model sagilio/Casbin.NET
2 participants
@hsluoyz @sagilio