New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit a merged PR which broke our Travis CI and the support for Caddy v2 #8
Comments
@closetool can you work on this? |
ok, I'll try to fix it |
@closetool coveralls is enabled: https://coveralls.io/github/casbin/caddy-authz?branch=master |
@hsluoyz yes, but some packages require go version over 1.14 like github.com/caddyserver/certmagic |
@closetool good to know! Please make a PR to fix the Go versions here: https://github.com/casbin/caddy-authz/blob/master/.travis.yml#L6 We usually test against several popular Go versions including tip. Please refer to Go Casbin repo for it. |
@closetool merged: #9 |
@closetool good to see CI recovered! But I saw the code coverage has dropped to 0%, can you investigate why? https://coveralls.io/github/casbin/caddy-authz?branch=master |
sure |
@hsluoyz I compared v2.0.0 and v1.0.2, and I found there's no |
good found! I think this PR: https://github.com/casbin/caddy-authz/pull/7/files deleted |
ok, I'll work on it |
See details at: #7 (comment)
The text was updated successfully, but these errors were encountered: