Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing async support (async-std + async adapter) #43

Closed
GopherJ opened this issue Jan 13, 2020 · 8 comments
Closed

Missing async support (async-std + async adapter) #43

GopherJ opened this issue Jan 13, 2020 · 8 comments
Assignees

Comments

@GopherJ
Copy link
Member

GopherJ commented Jan 13, 2020

casbin and diesel-adapter are synchronous, but it's worth adding async support to casbin and create a new async adapter.

https://github.com/async-rs/async-std
https://github.com/launchbadge/sqlx

The new adapter can be called sqlx-adapter, it's not ORM, but it's full asynchronous.

@GopherJ GopherJ self-assigned this Jan 13, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Jan 13, 2020

lgtm!

@GopherJ
Copy link
Member Author

GopherJ commented Feb 8, 2020

async-std has been added to casbin-rs in #53

@GopherJ
Copy link
Member Author

GopherJ commented Feb 9, 2020

sqlx is not very mature at this point, I'll add a sqlx-adapter later. Now we stick to https://github.com/casbin-rs/diesel-adapter

@GopherJ
Copy link
Member Author

GopherJ commented Feb 10, 2020

actix-web uses tokio as runtime, it's important to keep the async-std runtime and to add another feature called runtime-tokio. So that casbin-rs can works asynchronously in actix-web.

@mehcode
Copy link

mehcode commented Apr 1, 2020

sqlx is not very mature at this point [...]

@GopherJ Is there something in particular you were missing from SQLx? Happy to help prioritize any remaining pieces.

@GopherJ
Copy link
Member Author

GopherJ commented Apr 4, 2020

@mehcode @hackerchai is working on it and I think he has already everything he needs. So it's fine:) Thanks for making this cool library.

@hackerchai
Copy link
Member

@GopherJ @hsluoyz sqlx-adapter version 0.1.0 can be reviewed here: casbin-rs/sqlx-adapter#2

@GopherJ
Copy link
Member Author

GopherJ commented Apr 8, 2020

@GopherJ GopherJ closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants