Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Variables for DB creation #39

Closed
rico-ci opened this issue Aug 10, 2020 · 2 comments · Fixed by #40
Closed

Environment Variables for DB creation #39

rico-ci opened this issue Aug 10, 2020 · 2 comments · Fixed by #40
Assignees
@hsluoyz
Labels
enhancement New feature or request

Comments

@rico-ci
Copy link
Contributor

rico-ci commented Aug 10, 2020

There should be a way to use environment variables for the config file used by the adapter creation of CaaS. Hence, I suggest that users can add environment variables to casbin-server/config/connection_config.json by using $ followed by the name of the respective variable. Furthermore, users should be allowed to define whether a database has been created (through the dbSpecified keyword).
@rico-ci rico-ci mentioned this issue Aug 10, 2020
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Aug 10, 2020

@rico-ci can you make a PR?

@hsluoyz hsluoyz self-assigned this Aug 10, 2020
@hsluoyz hsluoyz added the enhancement New feature or request label Aug 10, 2020
@rico-ci
Copy link
Contributor Author

rico-ci commented Aug 10, 2020

Yes, either today or tomorrow.

@rico-ci rico-ci mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for environment variables in config file rico-ci/casbin-server
2 participants
@hsluoyz @rico-ci