Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions are welcome #1

Closed
hsluoyz opened this issue Jun 4, 2019 · 7 comments
Closed

Contributions are welcome #1

hsluoyz opened this issue Jun 4, 2019 · 7 comments
Assignees
Labels
enhancement Enhancement the exist feature good first issue Good for newcomers

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Jun 4, 2019

Currently, we have some unofficial implementations for C#. And maybe it's time to have an official one. I'm not sure if this code base is the best one, but suggestions are always welcome.

@xgenvn, can you help contribute to it?

@huazhikui, can you provide a to-do list?

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 4, 2019

After discussing with @huazhikui , the current status for this project is: has the same functionality with jCasbin: https://github.com/casbin/jcasbin, test cases are also included.

TO-DOs:

  1. Badges in README.md, including Travis CI, code coverage, Nuget, auto-generated docs (if any), code format, Gitter:

image

@xgenvn
Copy link

xgenvn commented Jun 5, 2019

@hsluoyz Already fork the project, can't wait to have some time investing on first PR ;).

@huazhikui
Copy link
Member

huazhikui commented Jun 5, 2019

@xgenvn @hsluoyz
TO-DO list:

  1. Util.LogPrint() method
  2. CoreEnforcer.SetWatcher method and Implementation class of IWatcher interface;

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 19, 2019

Hi @xgenvn , can you help fix the code coverage badge in README? https://github.com/casbin-net/Casbin.NET#casbinnet

@xgenvn
Copy link

xgenvn commented Jun 20, 2019

Hi @xgenvn , can you help fix the code coverage badge in README? https://github.com/casbin-net/Casbin.NET#casbinnet

I will take a look.

@xgenvn
Copy link

xgenvn commented Jul 7, 2019

Have to move workplace recently so no actual work on the badge yet. I have tried to configure the current package (coveralls.net) plus opencover, then have some issues with local libraries not found. Will take a look at other libraries how they do this. Sorry for the late response.

@hsluoyz
Copy link
Member Author

hsluoyz commented Jul 7, 2019

Hi @xgenvn , never mind. Thanks to @huazhikui, he had just made the badges work today :)

@hsluoyz hsluoyz self-assigned this Mar 12, 2020
@hsluoyz hsluoyz added enhancement Enhancement the exist feature good first issue Good for newcomers labels Mar 12, 2020
@hsluoyz hsluoyz closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement the exist feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants