Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the code warnings when building #34

Closed
hsluoyz opened this issue Jun 11, 2020 · 2 comments · Fixed by #36
Closed

Fix the code warnings when building #34

hsluoyz opened this issue Jun 11, 2020 · 2 comments · Fixed by #36
Assignees
Labels
enhancement Enhancement the exist feature help wanted Extra attention is needed

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Jun 11, 2020

Can we fix the following warnings?

  InternalEnforcer.cs(32, 48): [CS0168] The variable 'e' is declared but never used
  InternalEnforcer.cs(71, 48): [CS0168] The variable 'e' is declared but never used
  InternalEnforcer.cs(109, 48): [CS0168] The variable 'e' is declared but never used
  Config.cs(99, 36): [CS0168] The variable 'e' is declared but never used
  DefaultFileAdapter.cs(29, 32): [CS0168] The variable 'e' is declared but never used
  InternalEnforcer.cs(32, 48): [CS0168] The variable 'e' is declared but never used
  InternalEnforcer.cs(71, 48): [CS0168] The variable 'e' is declared but never used
  DefaultFileAdapter.cs(29, 32): [CS0168] The variable 'e' is declared but never used
  InternalEnforcer.cs(109, 48): [CS0168] The variable 'e' is declared but never used
  Config.cs(99, 36): [CS0168] The variable 'e' is declared but never used
  NuGet.Build.Tasks.Pack.targets(198, 5): [NU5125] The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
  NuGet.Build.Tasks.Pack.targets(198, 5): [NU5048] The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl

image

@hsluoyz hsluoyz self-assigned this Jun 11, 2020
@hsluoyz hsluoyz added the enhancement Enhancement the exist feature label Jun 11, 2020
@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 11, 2020

@huazhikui @xcaptain @sagilio

@hsluoyz hsluoyz added the help wanted Extra attention is needed label Jun 11, 2020
@sagilio
Copy link
Member

sagilio commented Jun 11, 2020

The warmings in InternalEnforcer.cs can be fixed when merged this PR Change update policy workflow. I will fix others at another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement the exist feature help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants